there are many ips at master.vc-mp.ovh/official that are there for many days and the servers are turned off
this is causing my custom vcmp browser to be very slow which is very bad especially for testing :(
It's very fast in my computer. Maybe is your network issue.
No. The official browser literally loads them in less than half a second. No exaggeration. However, even for only the official server list, my browser takes about 15 seconds to load them. I'm going to try to async them, but I'm not sure if I can do it easily
Servers will be purged automatically if they aren't online for a long time. I don't know why you wouldn't async load them in the first place though...
Quote from: Thijn on Jul 10, 2016, 02:09 PMServers will be purged automatically if they aren't online for a long time. I don't know why you wouldn't async load them in the first place though...
It will most likely shit things up if random stuff is happening at random times. The servers are removed if they aren't online, but I can see that this is unfortunately not the case with official server. I will copy paste my browsers output for the official list
[info] Initialized successfully
[info] Querying masterlist for all listed servers
[info] Adding servers to display
[ ok ] Load 164.132.200.179, 2194
[fail] Load 164.132.200.179, 2192
[ ok ] Load 46.105.184.128, 8194
[ ok ] Load 178.62.228.75, 8192
[ ok ] Load 91.121.134.5, 8192
[fail] Load 51.254.127.97, 8223
[fail] Load 5.135.145.71, 5196
[ ok ] Load 51.255.102.249, 8192
[ ok ] Load 51.255.102.244, 5196
[fail] Load 46.105.184.128, 8192
[ ok ] Load 79.98.29.42, 8192
[fail] Load 51.255.193.118, 8223
[fail] Load 51.255.193.118, 8192All the 'fail' servers aren't responding to my query and it times out on them.
:edit: Oh and don't care for the first 3, I hardcoded them onto my browser
[info] Initialized successfully
[info] Querying masterlist for all listed servers
[info] Adding servers to display
[ ok ] Load 164.132.200.179, 2194
[fail] Load 164.132.200.179, 2192
[ ok ] Load 46.105.184.128, 8194
[ ok ] Load 178.62.228.75, 8192
[ ok ] Load 91.121.134.5, 8192
[fail] Load 51.254.127.97, 8223
[fail] Load 5.135.145.71, 5196
[ ok ] Load 51.255.102.249, 8192
[ ok ] Load 51.255.102.244, 5196
[fail] Load 46.105.184.128, 8192
[ ok ] Load 79.98.29.42, 8192
[fail] Load 51.255.193.118, 8223
[fail] Load 51.255.193.118, 8192Okay next day and still 5 inactive servers on master.vc-mp.ovh/official
Just make your browser properly and you wont have any problems. Just like the official or ysc's browser.
Or just use the original browser and you won't have such problem like the rest of us.
We disabled the cron job responsible for pruning inactive servers a while ago for two reasons:
- At the time we disabled the cron job, there was a massive UDP flood attack on the masterlist server that forced us to disable UDP traffic to keep the server up. This prevented us from determining whether a server is up or not.
- The effect of querying inactive servers in our official browser is negligible.
Quote from: ext-d.CrystalBlue on Jul 10, 2016, 12:34 PMthis is causing my custom vcmp browser to be very slow which is very bad especially for testing :(
This is your programming problem to deal with, not ours.
Okay then I'm going to try to async them
I hope it wont ruin my console
Quote from: Stormeus on Jul 12, 2016, 03:50 PMWe disabled the cron job responsible for pruning inactive servers a while ago for two reasons:
- At the time we disabled the cron job, there was a massive UDP flood attack on the masterlist server that forced us to disable UDP traffic to keep the server up. This prevented us from determining whether a server is up or not.
- The effect of querying inactive servers in our official browser is negligible.
Quote from: ext-d.CrystalBlue on Jul 10, 2016, 12:34 PMthis is causing my custom vcmp browser to be very slow which is very bad especially for testing :(
This is your programming problem to deal with, not ours.
I think you should remove it if a server haven't announced for some time(such as 7 days).
Quote from: ext-d.CrystalBlue on Jul 10, 2016, 12:34 PMthis is causing my custom vcmp browser to be very slow which is very bad especially for testing :(
You are using "blocked sockets", which means your program will wait for remote computer's reply. You should use "non-blocked sockets".
Quote from: Thijn on Jul 12, 2016, 03:38 PMJust make your browser properly and you wont have any problems. Just like the official or ysc's browser.
I disassemblyed the official browser and found it starts a thread to receive data. However, I use WSAAsyncSelect to register a Windows message. When the remote computer sends me data, I will receive that message. See "WM_SOCKET" in VCMPBrowser.cpp:804.
Do you mean async?
Because if the socket doesn't block the code then it will try to read the packet that hasn't arrived yet