[Bug]Client not downloading all store files

Started by habi2, Oct 09, 2024, 10:58 PM

Previous topic - Next topic

habi2



Description
When n the number of new/changed store-files required by client exceeds 255, n wraps around 255.
Eg. If client needs 257 store, files it ask only 1.

Reproducible
Always

What you were doing when the bug happened
I found that it is two bytes when server tell client the total store files. But when client request, it is only one byte. So i created more than 250 fake files in store/script. And found to my surprise only one of them was downloaded (file107.txt). All the rest was missed !

What you think caused the bug
Writing it as one-byte in client-to server packet 0x58 ( 0.4.7.1 )