Good job VCMP Developers, you messed up real good this time

Started by DizzasTeR, Jun 16, 2017, 09:41 PM

Previous topic - Next topic

DizzasTeR

[Insert immature bullshit from 2017 here]


.

I did some testing. Just a basic copy paste and then compiled. The generated hash was correct. Then tried on the official plugin with the same text. The generated hash was again correct. Dunno what happens but something is just messaged with the way he chooses to hash the passwords.

I can't really disclose his exact process but even I told him it was a bad idea the way he chose to do it. I'll further consult with him when I get back, because it seems to be just a mistake in porting code. I guess after so many hours he got a little pissed of at the prospect of loosing everything.
.

.

The issue apparently stems from the base64_encode() function in the official plugin which added a new line character at the end. Everything seems to work as expected now after he adds a new line to his result.

Sorry for the caused trouble. However, for anyone that may hash output from base64_encode(). Be careful with that trailing newline.
.

DizzasTeR

Its not just a new line

The SHA1 in the official plugin returns a upper case hash, which is not a normal behavior, secondly base encode adds a new line which is again not an expected behavior, again WHIRLPOOL returns a upper case hash without a reason.

This means all of these had to be done manually to make the results work with the hashes generated by official plugins.

I'm glad SLC saved me from giving up and losing all of the time I spent editing each line here, Thanks, I know I've acted abit retarded and rude but trust me I've spent too much time and such an end would literally make anyone crazy.

Stormeus

Quote from: Doom_Kill3R on Jun 16, 2017, 11:03 PMThe SHA1 in the official plugin returns a upper case hash, which is not a normal behavior

What on earth are you on about? Nowhere in any cryptographic hash function specification does it say string representations of hashes must be lowercase. If you really want to fight it, take it up with the Crypto++ developers: https://github.com/weidai11/cryptopp/issues

Quote from: Doom_Kill3R on Jun 16, 2017, 11:03 PMsecondly base encode adds a new line which is again not an expected behavior

This is required by MIME Base64.

https://stackoverflow.com/a/28500964
https://en.wikipedia.org/wiki/Base64#Examples

Don't waste my time with this kind of melodrama.

DizzasTeR

[Mature level: 0]