Error GetTeam

[FinchDon]

I add this onScriptLoad

random <- [ 1, 2, 3, 4 ];

and add this on Player Register

local team = random[rand()% random.len()]
      ::QuerySQL( dbGlobal, "INSERT INTO Accounts VALUES( '" + team + "' )" );

and this is Command

Code Select Expand

if ( cmd == "myteam")
{
if ( GetTeam( player ) == 1 ) MessagePlayer( "[#FF0000]MaaKi", player );
if ( GetTeam( player ) == 2 ) MessagePlayer( "[#66FF33]Fabular", player );
if ( GetTeam( player ) == 3 ) MessagePlayer( "[#6666FF]Cmon Master", player );
if ( GetTeam( player ) == 4 ) MessagePlayer( "[#FFFF00]You are noob", player );
}

Releated Functions

Code Select Expand

function SetTeam( player, amount )
{
      QuerySQL(sqliteDB, "UPDATE Accounts SET Group='" +  amount + "' WHERE Name='" + player.Name + "'");   
}

function GetTeam( player )
{
   local lvl1 =  GetSQLColumnData( QuerySQL( sqliteDB, "SELECT Group FROM Accounts WHERE Name='" + player.Name+"'" ), 0 );
   if ( lvl1 ) return lvl1;
   else return 0;
}

Now When i Registered and check in database it show Group Random sometime 1 or 2 or 3 But when i do /myteam it show nothing i add this on Command

if ( GetTeam( player ) == 0 ) PrivMessage( player, "xD" );

then it show that message but in database it was team 2
      

[Thijn]

Ouch. 4 queries each time you to do /myteam. That's gonna lag like shit when abused.

That insert query makes no sense. Do you really only have 1 column in your Accounts table?

[FinchDon]

Nah it is this

Code Select Expand

::QuerySQL( dbGlobal, "INSERT INTO Accounts VALUES('" + player.Name + "', '" + player.Name.tolower() + "', '" + ( password ) + "', 0, 0, 0, 0, 1, '" + player.IP + "', '" + team + "' )" );


[MacTavish]

Nah it is this

Code Select Expand

::QuerySQL( dbGlobal, "INSERT INTO Accounts VALUES('" + player.Name + "', '" + player.Name.tolower() + "', '" + ( password ) + "', 0, 0, 0, 0, 1, '" + player.IP + "', '" + team + "' )" );


Invalid Query

actually it would have to be like this

Code Select Expand

::QuerySQL( dbGlobal, "INSERT INTO Accounts (Name, NameTolower, Password, thingone, thingtwo, thingthree, thingfour, thingfive, IP, Group ) VALUES('" + player.Name + "', '" + player.Name.tolower() + "', '" + ( password ) + "', 0, 0, 0, 0, 1, '" + player.IP + "', '" + team + "' )" );


And second thing your myteam cmd is wrong,

You using

if
if

This prevents operation to check next condition
Actually it should be like this

Code Select Expand

if ( cmd == "myteam")
 {
 if ( GetTeam( player ) == 1 ) MessagePlayer( "[#FF0000]MaaKi", player );
else if ( GetTeam( player ) == 2 ) MessagePlayer( "[#66FF33]Fabular", player );
else if ( GetTeam( player ) == 3 ) MessagePlayer( "[#6666FF]Cmon Master", player );
 else if ( GetTeam( player ) == 4 ) MessagePlayer( "[#FFFF00]You are noob", player );
 }

[KAKAN]

It's better to use array for it instead of using Query each time, I mean you can save it in DB, but load it on an array onplayerjoin, you can see FAS for more details.

[Thijn]

Nah it is this

Code Select Expand

::QuerySQL( dbGlobal, "INSERT INTO Accounts VALUES('" + player.Name + "', '" + player.Name.tolower() + "', '" + ( password ) + "', 0, 0, 0, 0, 1, '" + player.IP + "', '" + team + "' )" );


Invalid Query

actually it would have to be like this

Code Select Expand

::QuerySQL( dbGlobal, "INSERT INTO Accounts (Name, NameTolower, Password, thingone, thingtwo, thingthree, thingfour, thingfive, IP, Group ) VALUES('" + player.Name + "', '" + player.Name.tolower() + "', '" + ( password ) + "', 0, 0, 0, 0, 1, '" + player.IP + "', '" + team + "' )" );


And second thing your myteam cmd is wrong,

You using

if
if

This prevents operation to check next condition
Actually it should be like this

Code Select Expand

if ( cmd == "myteam")
 {
 if ( GetTeam( player ) == 1 ) MessagePlayer( "[#FF0000]MaaKi", player );
else if ( GetTeam( player ) == 2 ) MessagePlayer( "[#66FF33]Fabular", player );
else if ( GetTeam( player ) == 3 ) MessagePlayer( "[#6666FF]Cmon Master", player );
 else if ( GetTeam( player ) == 4 ) MessagePlayer( "[#FFFF00]You are noob", player );
 }

You're wrong in both occasions. That query is perfectly valid, as long as he defines each column.
And while not using else if, but just if is inefficient, it certainly works.

[MacTavish]

Nah it is this

Code Select Expand

::QuerySQL( dbGlobal, "INSERT INTO Accounts VALUES('" + player.Name + "', '" + player.Name.tolower() + "', '" + ( password ) + "', 0, 0, 0, 0, 1, '" + player.IP + "', '" + team + "' )" );


Invalid Query

actually it would have to be like this

Code Select Expand

::QuerySQL( dbGlobal, "INSERT INTO Accounts (Name, NameTolower, Password, thingone, thingtwo, thingthree, thingfour, thingfive, IP, Group ) VALUES('" + player.Name + "', '" + player.Name.tolower() + "', '" + ( password ) + "', 0, 0, 0, 0, 1, '" + player.IP + "', '" + team + "' )" );


And second thing your myteam cmd is wrong,

You using

if
if

This prevents operation to check next condition
Actually it should be like this

Code Select Expand

if ( cmd == "myteam")
 {
 if ( GetTeam( player ) == 1 ) MessagePlayer( "[#FF0000]MaaKi", player );
else if ( GetTeam( player ) == 2 ) MessagePlayer( "[#66FF33]Fabular", player );
else if ( GetTeam( player ) == 3 ) MessagePlayer( "[#6666FF]Cmon Master", player );
 else if ( GetTeam( player ) == 4 ) MessagePlayer( "[#FFFF00]You are noob", player );
 }

You're wrong in both occasions. That query is perfectly valid, as long as he defines each column.
And while not using else if, but just if is inefficient, it certainly works.

Really? i never tested those ways thats why i thought that

[FinchDon]

So What is Error :\

[Thijn]

Do a print on that command.
You really have no clue how to debug stuff, do you? ...

[FinchDon]

Ya I use That

Code Select Expand

if ( cmd == "a")
{
PrivMessage( player, " ahh " + GetTeam( player ) + ".");
}
But it too show Group 0 Where it is 2 in Database

Code Select Expand

function GetTeam( player )
{
   local lvl1 =  GetSQLColumnData( QuerySQL( sqliteDB, "SELECT Group FROM Accounts WHERE Name='" + player.Name+"'" ), 0 );
   if ( lvl1 ) return lvl1;
   else return 0;
}


[Xmair]

Post your table creating line.

[FinchDon]

I Create Table By Opening Database I open Database and edit Accounts table and add There. Group NUMERIC

[KAKAN]

POST your CREATE TABLE IF NOT EXISTS FUNCTION

[FinchDon]

I dont have that function

[MacTavish]

POST your CREATE TABLE IF NOT EXISTS FUNCTION

He created that column manually by db browser, not by the function