I noticed that you revert the "Fix print issue" commit made by me. Have you tested if the old code works well? I tested in old version, when you print more than 512 chars, the server won't crash immediately, but the stack is broken and maybe crash later. I will test it again on weekend(because I only can use computer on weekends)
Server/Squirrel Update Released (March 1)
ysc3839
-
- VC:MP Beta Tester
-
- Posts: 622
Stormeus
-
- VC:MP Developer
-
- oh god how did i get here im not good w computer
- Posts: 1,127
The print issue fix was reverted because it only measured the length of the format string, which resulted in error messages being cut off.
KAKAN
- Wiki Contributor
-
- Posts: 3,343
What about the sockets anyways? Fix the bugs of the Sockets plugin too, please!
And also, I can't open the server's download link, any mirrors?
And also, I can't open the server's download link, any mirrors?
oh no
ysc3839
-
- VC:MP Beta Tester
-
- Posts: 622
The print issue fix was reverted because it only measured the length of the format string, which resulted in error messages being cut off.
Also I want to know why the CCore::rawprint uses fputs instead of functions->printf
Code: [Select]
void CCore::rawprint(const char * pszOutput)
{
fputs(pszOutput, stdout);
if (this->pLogFile != NULL)
fprintf(this->pLogFile, "%s", pszOutput);
}After searching Internet I found there's some difference between MSVC's snprintf and gcc's. We have been "tricked" by MS. >:(
Re: Server/Squirrel Update Released (March 1)
« Reply #21, on March 5th, 2016, 01:03 PM »Last edited on March 5th, 2016, 02:58 PM
Tested on VS2013 and VS2015. I found that VS2013 doesn't have "snprintf" but have "_snprintf". However, VS2015 have both "snprintf" and "_snprintf". And it's "snprintf" functions like gcc's.
Also, the plugin still have print issue.
:edit:Linux version doesn't have this issue.
Also, the plugin still have print issue.
:edit:Linux version doesn't have this issue.
I have made a pull-request. :)
kingofpopYT
- Newbie
- Posts: 18