Squirrel plugin small bug / player.IP return 0.0.0.0

Started by rww, Apr 18, 2015, 08:52 PM

Previous topic - Next topic

rww

GetVehicleModelFromName have some missings

After update missing too:
- Fbi Car
- FBI Rancher
- Pony

//============

Another bug:

function onPlayerPart(p,r)
{
print("[PART] ["+p.ID+"] [ "+p.Name+" ] IP: [ "+p.IP+" ] UID: [ "+p.UniqueID+" ]");
return 1;
}

Join to Irrelevant Club Discord: https://discord.gg/MsPPZ5uV4X

.

Are you sure you got the names right? Could you show us the code you used for testing? Or, at least the names you used to call that function.
.

rww

Quote from: S.L.C on Apr 18, 2015, 11:53 PMAre you sure you got the names right? Could you show us the code you used for testing? Or, at least the names you used to call that function.

Yes, because in FunctionHandler.cpp

case 'b':
{
if( lowername[1] == 'o' )
{
if( strlen( lowername ) >= 3 )
{
if( lowername[2] == 'b' )
res = 152; // bobcat
else if( lowername[2] == 'x' )
res = 228; // boxville
}
}
else if( lowername[1] == 'a' )
{
if( strlen( lowername ) >= 3 )
{
if( lowername[2] == 'r' )
res = 163; // barracks ol
else if( lowername[2] == 'g' )
res = 215; // baggage handler
}
}
else if( lowername[1] == 'l' )
res = 226; // blista compact
else if( lowername[1] == 'e' )
res = 229; // benson

break;
}

where is banshee in this code?

I use /v [car name] for car spawn

/v blista work but /v banshee doesn't work etc...
Join to Irrelevant Club Discord: https://discord.gg/MsPPZ5uV4X

Stormeus

#3
For bookkeeping purposes, please don't report two bugs in one thread. It makes tracking individual issues harder to deal with.

Some of those cars should already be tracked by Squirrel. Some of those cars don't even exist in VC (FBI Car is III; only the Cuban Jetmax exists in VC, what is Jetmax?). The rest will be handled accordingly.

Does the 0.0.0.0 issue occur always, often or rarely?

.

This is the one that I use in my plugin. If you can remove the C++ specific code such as the algorithms used to clean the name and and the use of the standard string. Then you are free to use it in your code. I rewrote, most of the identification functions from scratch and I remember I included all the models. The one for the skin might be bugged and it's waiting for a revision. But other than that, they can all be found in the Misc/Identifiers.cpp on the repository.
.

DizzasTeR

Players also reported me about the comet not spawning, but not sure about the rest of the vehicles, I remember typing the ID of these car works but typing the name doesn't recognize it.

rww

Quote from: stormeus on Apr 19, 2015, 12:07 AMFor bookkeeping purposes, please don't report two bugs in one thread. It makes tracking individual issues harder to deal with.

Some of those cars should already be tracked by Squirrel. Some of those cars don't even exist in VC (FBI Car is III; only the Cuban Jetmax exists in VC, what is Jetmax?). The rest will be handled accordingly.

Does the 0.0.0.0 issue occur always, often or rarely?



After update missing too:
- Fbi Car
- FBI Rancher
- Pony
Join to Irrelevant Club Discord: https://discord.gg/MsPPZ5uV4X

Gudio

To reproduce this issue, you can kick the player in onPlayerJoin callback.

Stormeus


Gudio

Quote from: rwwpl on Apr 19, 2015, 10:34 AM- Fbi Car
- FBI Rancher
You need to type at least 4 characters. For example: fbi w or fbi r.
Pony was fixed in SVN.

rObInX


Kratos_

In the middle of chaos , lies opportunity.

rww

Quote from: rObInX on Apr 20, 2015, 01:22 AMHe talking about FBI Cheeta.

No, FBI Wash, but game files is FBI Car. FBI Cheeta is Vice Cheetah.
Join to Irrelevant Club Discord: https://discord.gg/MsPPZ5uV4X